Skip to content

Conversation

@amaliujia
Copy link
Contributor

What changes were proposed in this pull request?

Remove stale entries from the excluding rules for CompatibilitySuite.

Why are the changes needed?

Keep API compatibility list in sync.

Does this PR introduce any user-facing change?

NO

How was this patch tested?

UT

@amaliujia
Copy link
Contributor Author

@hvanhovell @LuciferYang

@amaliujia
Copy link
Contributor Author

We may have #40213 merged first since that looks pretty good already.

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

Copy link
Contributor

@hvanhovell hvanhovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@hvanhovell
Copy link
Contributor

Merging.

@hvanhovell hvanhovell closed this in 2e6ce42 Mar 2, 2023
hvanhovell pushed a commit that referenced this pull request Mar 2, 2023
…for CompatibilitySuite

### What changes were proposed in this pull request?

Remove stale entries from the excluding rules for CompatibilitySuite.

### Why are the changes needed?

Keep API compatibility list in sync.

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

UT

Closes #40241 from amaliujia/remove_entries.

Authored-by: Rui Wang <rui.wang@databricks.com>
Signed-off-by: Herman van Hovell <herman@databricks.com>
(cherry picked from commit 2e6ce42)
Signed-off-by: Herman van Hovell <herman@databricks.com>
snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
…for CompatibilitySuite

### What changes were proposed in this pull request?

Remove stale entries from the excluding rules for CompatibilitySuite.

### Why are the changes needed?

Keep API compatibility list in sync.

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

UT

Closes apache#40241 from amaliujia/remove_entries.

Authored-by: Rui Wang <rui.wang@databricks.com>
Signed-off-by: Herman van Hovell <herman@databricks.com>
(cherry picked from commit 2e6ce42)
Signed-off-by: Herman van Hovell <herman@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants