[SPARK-45593][BUILD][FOLLOWUP] Correct relocation connect guava dependency #44801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@LuciferYang Please take a look |
yikf
force-pushed
the
SPARK-45593-SBT
branch
3 times, most recently
from
0d88e01 to
a455129
Compare
LuciferYang
changed the title
LuciferYang
approved these changes
Jan 24, 2024
LuciferYang
changed the title
Contributor
|
Merged into master for Spark 4.0. Thanks @yikf |
LuciferYang
pushed a commit
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? This PR amins to correct relocation connect guava dependency and remove duplicate connect-common from SBT build jars. This PR cherry-pick from #43436 and #44801 as a backport to 3.5 branch. ### Why are the changes needed? Bugfix ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Follow the steps described at #43195 (comment) to test manually. In addition, will continue to observe the GA situation in recent days. ### Was this patch authored or co-authored using generative AI tooling? No Closes #45775 from Yikf/branch-3.5. Authored-by: yikaifei <yikaifei@apache.org> Signed-off-by: yangjie01 <yangjie01@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR amins to correct relocation connect guava dependency and remove duplicate connect-common from SBT build jars.
Item 1: In #43436, We fixed the connect module dependency on guava, but the dependency on guava was relocation incorrectly.
Item2: Remove duplicate connect-common from SBT build jars as it is shaded in the spark connect. Also, in fact, before this PR, in the output jars built using SBT, connect-common and common-server were the same thing, because they both hit the
jar.getName.contains("spark-connect")condition.Why are the changes needed?
Bugfix
Does this PR introduce any user-facing change?
No
How was this patch tested?
GA
Was this patch authored or co-authored using generative AI tooling?
No.