Skip to content

Conversation

@yikf
Copy link
Contributor

@yikf yikf commented Mar 29, 2024

What changes were proposed in this pull request?

This PR amins to correct relocation connect guava dependency and remove duplicate connect-common from SBT build jars.

This PR cherry-pick from #43436 and #44801 as a backport to 3.5 branch.

Why are the changes needed?

Bugfix

Does this PR introduce any user-facing change?

No

How was this patch tested?

Follow the steps described at #43195 (comment) to test manually.

In addition, will continue to observe the GA situation in recent days.

Was this patch authored or co-authored using generative AI tooling?

No

@yikf
Copy link
Contributor Author

yikf commented Mar 29, 2024

@LuciferYang Please take a look if you find a time, thanks

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM
Thanks @yikf

LuciferYang pushed a commit that referenced this pull request Apr 1, 2024
### What changes were proposed in this pull request?

This PR amins to correct relocation connect guava dependency and remove duplicate connect-common from SBT build jars.

This PR cherry-pick from #43436 and #44801 as a backport to 3.5 branch.

### Why are the changes needed?

Bugfix

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Follow the steps described at #43195 (comment) to test manually.

In addition, will continue to observe the GA situation in recent days.

### Was this patch authored or co-authored using generative AI tooling?

No

Closes #45775 from Yikf/branch-3.5.

Authored-by: yikaifei <yikaifei@apache.org>
Signed-off-by: yangjie01 <yangjie01@baidu.com>
@LuciferYang LuciferYang closed this Apr 1, 2024
@LuciferYang
Copy link
Contributor

Merged into branch-3.5. Thanks @yikf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants