[SPARK-48048][CONNECT][SS] Added client side listener support for Scala#46287
Closed
bogao007 wants to merge 5 commits intoapache:masterfrom
Closed
[SPARK-48048][CONNECT][SS] Added client side listener support for Scala#46287bogao007 wants to merge 5 commits intoapache:masterfrom
bogao007 wants to merge 5 commits intoapache:masterfrom
Conversation
WweiL
reviewed
Apr 29, 2024
Contributor
WweiL
left a comment
WweiL
left a comment
There was a problem hiding this comment.
Thanks! Left some comments
...onnect/client/jvm/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryListener.scala
Outdated
Show resolved
Hide resolved
...ect/client/jvm/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryListenerBus.scala
Outdated
Show resolved
Hide resolved
...ect/client/jvm/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryListenerBus.scala
Outdated
Show resolved
Hide resolved
...ect/client/jvm/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryListenerBus.scala
Show resolved
Hide resolved
bogao007
changed the title
WweiL
reviewed
May 1, 2024
...ect/client/jvm/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryListenerBus.scala
Outdated
Show resolved
Hide resolved
bogao007
changed the title
HyukjinKwon
approved these changes
May 1, 2024
Member
|
Merged to master. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 10, 2025
…rom `connect.StreamingQueryManager` ### What changes were proposed in this pull request? #41752 introduced a `listenerCache` and related private methods (`cacheListenerById`, `getIdByListener`, and `removeCachedListener`) for `connect.StreamingQueryManager`. However, in #46287, the usage related to `listenerCache` was replaced by `streamingQueryListenerBus`. As a result, `listenerCache` and its associated private methods are no longer in use, and this current pr cleans them up. ### Why are the changes needed? Code cleanup. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass Github Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #53420 from LuciferYang/StreamingQueryManager. Lead-authored-by: yangjie01 <yangjie01@baidu.com> Co-authored-by: YangJie <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added client side Streaming Listener support for Scala
Why are the changes needed?
Support Streaming Listener on client side for Spark Connect which has better user experience (no breaking change compared to legacy mode) compared to previous server side listener.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added unit test.
Was this patch authored or co-authored using generative AI tooling?
No.