[SPARK-54664][CONNECT] Clean up the code related to listenerCache from connect.StreamingQueryManager#53420
Closed
LuciferYang wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-54664][CONNECT] Clean up the code related to listenerCache from connect.StreamingQueryManager#53420LuciferYang wants to merge 4 commits intoapache:masterfrom
listenerCache from connect.StreamingQueryManager#53420LuciferYang wants to merge 4 commits intoapache:masterfrom
Conversation
LuciferYang
changed the title
listenerCache from connect.StreamingQueryManagerlistenerCache from connect.StreamingQueryManager
dongjoon-hyun
approved these changes
Dec 10, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @LuciferYang .
Merged to master for Apache Spark 4.2.0.
Contributor
Author
|
Thank you @dongjoon-hyun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#41752 introduced a
listenerCacheand related private methods (cacheListenerById,getIdByListener, andremoveCachedListener) forconnect.StreamingQueryManager. However, in #46287, the usage related tolistenerCachewas replaced bystreamingQueryListenerBus. As a result,listenerCacheand its associated private methods are no longer in use, and this current pr cleans them up.Why are the changes needed?
Code cleanup.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass Github Actions
Was this patch authored or co-authored using generative AI tooling?
No