[SPARK-48167][CONNECT][TESTS] Skip known behaviour change by SPARK-46122 #46430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
approved these changes
May 7, 2024
Member
Author
|
Merged to branch-3.5. |
HyukjinKwon
added a commit
that referenced
this pull request
May 7, 2024
### What changes were proposed in this pull request? This PR proposes to skip `test_create_without_provider` in backward compatibility test in https://github.com/apache/spark/actions/workflows/build_python_connect35.yml ### Why are the changes needed? This is a intentional behaviour change (SPARK-46122) ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Tested in my fork ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46430 from HyukjinKwon/SPARK-48167. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
| self.assertEqual(100, self.spark.sql("select * from test_table").count()) | ||
|
|
||
| @unittest.skipIf( | ||
| "SPARK_SKIP_CONNECT_COMPAT_TESTS" in os.environ, "Known behavior change in 4.0") |
Member
There was a problem hiding this comment.
It seems that branch-3.5 has different linter rule.
I made a follow-up to recover branch-3.5 CI.
dongjoon-hyun
added a commit
that referenced
this pull request
May 7, 2024
…py to fix Python Linter error ### What changes were proposed in this pull request? This is a follow-up of #46430 to fix Python linter failure. ### Why are the changes needed? To recover `branch-3.5` CI, - https://github.com/apache/spark/actions/runs/8981228745/job/24666400664 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass Python Linter in this PR builder. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46445 from dongjoon-hyun/SPARK-48167. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to skip
test_create_without_providerin backward compatibility test in https://github.com/apache/spark/actions/workflows/build_python_connect35.ymlWhy are the changes needed?
This is a intentional behaviour change (SPARK-46122)
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
Tested in my fork
Was this patch authored or co-authored using generative AI tooling?
No.