[SPARK-51842][SQL] Remove unnecessary judgement from fillDefaultValue #50633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beliefer
changed the title
Contributor
Author
|
ping @cloud-fan cc @viirya |
Member
|
LGTM barring merge conflicts. |
# Conflicts: # sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala
beliefer
force-pushed
the
investigate-default-is-null
branch
from
f08cace to
4199285
Compare
cloud-fan
reviewed
May 1, 2025
| protected val fillDefaultValue = { | ||
| // Collect the expressions and bind them. | ||
| val boundExpressions = Seq.fill(ordinal)(NoOp) ++ expressions.toImmutableArraySeq.map { e => | ||
| if (e.default == null) { |
Contributor
There was a problem hiding this comment.
It's not clear to me why this is not possible to happen, and I don't think it's worth the time to figure it out. This null check doesn't hurt at all.
Contributor
Author
There was a problem hiding this comment.
Got it. Maybe there is a chance in future. Let's hold this PR.
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove unnecessary judgement from
fillDefaultValue.Why are the changes needed?
Currently, there is a judgement
e.default == nullwhile declaringfillDefaultValue.After an investigation, there should not be a value of primitive type here. It might be a literal null even if users specify null as the default value.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
No.