Skip to content

[SPARK-51842][SQL] Remove unnecessary judgement from fillDefaultValue #50633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
beliefer wants to merge 1 commit into from
Closed

[SPARK-51842][SQL] Remove unnecessary judgement from fillDefaultValue #50633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,7 @@ abstract class OffsetWindowFunctionFrameBase(
protected val fillDefaultValue = {
// Collect the expressions and bind them.
val boundExpressions = Seq.fill(ordinal)(NoOp) ++ expressions.toImmutableArraySeq.map { e =>
if (e.default == null) {
Copy link
Contributor

@cloud-fan cloud-fan May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me why this is not possible to happen, and I don't think it's worth the time to figure it out. This null check doesn't hurt at all.

Copy link
Contributor Author

@beliefer beliefer May 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Maybe there is a chance in future. Let's hold this PR.

// The default value is null.
Literal.create(null, e.dataType)
} else if (e.default.foldable) {
if (e.default.foldable) {
// The default value is foldable.
Literal.create(e.default.eval(), e.dataType)
} else {
Expand Down