-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-8265] [MLlib] [PySpark] Add LinearDataGenerator to pyspark.mllib.utils #6715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc: @davies Please have a look. |
|
Test build #34492 has finished for PR 6715 at commit
|
504ae9a to
b10ced1
Compare
|
ping @mengxr I fixed the minor style fixes and pushed. Hopefully it should look good now. |
|
Test build #35148 has finished for PR 6715 at commit
|
|
Test build #35147 has finished for PR 6715 at commit
|
|
jenkins retest this please |
python/pyspark/mllib/tests.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use named arguments to make the code more readable
|
Test build #35162 has finished for PR 6715 at commit
|
|
@mengxr Thanks for your comments. I have addressed them. |
|
Test build #35221 has finished for PR 6715 at commit
|
1bce3f5 to
3e5b51d
Compare
|
Test build #35224 has finished for PR 6715 at commit
|
3e5b51d to
6182884
Compare
|
Rebased over master. |
|
Test build #35312 has finished for PR 6715 at commit
|
|
LGTM. Merged into master. Thanks! Apache JIRA is down. I will update the JIRA later. |
It is useful to generate linear data for easy testing of linear models and in general. Scala already has it. This is just a wrapper around the Scala code.