Skip to content

Conversation

@MechCoder
Copy link
Contributor

It is useful to generate linear data for easy testing of linear models and in general. Scala already has it. This is just a wrapper around the Scala code.

@MechCoder
Copy link
Contributor Author

cc: @davies Please have a look.

@SparkQA
Copy link

SparkQA commented Jun 9, 2015

Test build #34492 has finished for PR 6715 at commit f234b4c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class LinearDataGenerator(object):

@MechCoder
Copy link
Contributor Author

ping @mengxr I fixed the minor style fixes and pushed. Hopefully it should look good now.

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #35148 has finished for PR 6715 at commit b10ced1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class LinearDataGenerator(object):

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #35147 has finished for PR 6715 at commit 504ae9a.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds the following public classes (experimental):
    • class LinearDataGenerator(object):

@MechCoder
Copy link
Contributor Author

jenkins retest this please

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use named arguments to make the code more readable

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #35162 has finished for PR 6715 at commit b10ced1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class LinearDataGenerator(object):

@MechCoder
Copy link
Contributor Author

@mengxr Thanks for your comments. I have addressed them.

@SparkQA
Copy link

SparkQA commented Jun 19, 2015

Test build #35221 has finished for PR 6715 at commit 1bce3f5.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class LinearDataGenerator(object):

@MechCoder MechCoder force-pushed the generate_linear_input branch from 1bce3f5 to 3e5b51d Compare June 19, 2015 04:48
@SparkQA
Copy link

SparkQA commented Jun 19, 2015

Test build #35224 has finished for PR 6715 at commit 3e5b51d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class LinearDataGenerator(object):

@MechCoder MechCoder force-pushed the generate_linear_input branch from 3e5b51d to 6182884 Compare June 19, 2015 19:32
@MechCoder
Copy link
Contributor Author

Rebased over master.

@SparkQA
Copy link

SparkQA commented Jun 19, 2015

Test build #35312 has finished for PR 6715 at commit 6182884.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • // class ParentClass(parentField: Int)
    • // class ChildClass(childField: Int) extends ParentClass(1)
    • // If the class type corresponding to current slot has writeObject() defined,
    • // then its not obvious which fields of the class will be serialized as the writeObject()
    • class StreamingKMeansModel(KMeansModel):
    • class StreamingKMeans(object):
    • class LinearDataGenerator(object):
    • abstract class GeneratedClass
    • case class Md5(child: Expression)

@mengxr
Copy link
Contributor

mengxr commented Jun 23, 2015

LGTM. Merged into master. Thanks! Apache JIRA is down. I will update the JIRA later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants