[SPARK-7835] Refactor HeartbeatReceiverSuite for coverage + cleanup #7173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it covers expiring dead hosts and has much less duplicate code.
Contributor
Author
This was referenced Jul 2, 2015
|
Merged build triggered. |
|
Merged build started. |
|
Test build #36323 has started for PR 7173 at commit |
|
Test build #36323 has finished for PR 7173 at commit
|
|
Merged build finished. Test PASSed. |
Contributor
Author
|
Merging into master. |
asfgit
pushed a commit
that referenced
this pull request
Jul 14, 2015
As of #7173 we expect executors to properly register with the driver before responding to their heartbeats. This behavior is not matched in local mode. This patch adds the missing event that needs to be posted. Author: Andrew Or <andrew@databricks.com> Closes #7382 from andrewor14/fix-local-heartbeat and squashes the following commits: 1258bdf [Andrew Or] Post ExecutorAdded event to local executor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing test suite has a lot of duplicate code and doesn't even cover the most fundamental feature of the HeartbeatReceiver, which is expiring hosts that have not responded in a while.
This introduces manual clocks in
HeartbeatReceiverand makes it respond to heartbeats only for registered executors. A few internal messages are moved toreceiveAndReplyto increase determinism of the tests so we don't have to rely on flaky constructs likeeventually.