[SPARK-8911] Fix local mode endless heartbeats #7382
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewor14
force-pushed
the
fix-local-heartbeat
branch
from
b504c09 to
1e466a6
Compare
Otherwise HeartbeatReceiver will keep expecting but never get a proper registration.
andrewor14
force-pushed
the
fix-local-heartbeat
branch
from
1e466a6 to
1258bdf
Compare
|
Test build #37172 has finished for PR 7382 at commit
|
|
Test build #37173 has finished for PR 7382 at commit
|
Contributor
Author
|
retest this please |
|
Test build #37203 has finished for PR 7382 at commit
|
Contributor
|
LGTM. |
Contributor
|
@andrewor14 can you merge this if this is ready ? The log messages make testing / debugging on a local shell very painful. |
Contributor
Author
|
Ok, merging into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #7173 we expect executors to properly register with the driver before responding to their heartbeats. This behavior is not matched in local mode. This patch adds the missing event that needs to be posted.