Skip to content

Conversation

@ggupta81
Copy link

@ggupta81 ggupta81 commented Jul 6, 2015

In current implementation, First and Last aggregates were calculating the values for entire DataFrame partition and then the same value was returned for all GroupedData in the partition.
Fixed the First and Last aggregates to compute first and last value per GroupedData instead of entire DataFrame

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@andrewor14
Copy link
Contributor

@ggupta81 please file a JIRA and open a patch against the master branch. For more detail see https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark and how other PRs are opened.

@JoshRosen
Copy link
Contributor

Let's close this issue for now.

@JoshRosen
Copy link
Contributor

Actually, @rxin or @yhuai, is this a bug that should be fixed for 1.5?

@ggupta81
Copy link
Author

ggupta81 commented Aug 4, 2015

I have opened a JIRA issue:
https://issues.apache.org/jira/browse/SPARK-9592

and created pull request on master:
#7928

On Sat, Aug 1, 2015 at 11:58 PM, Josh Rosen notifications@github.com
wrote:

Actually, @rxin https://github.com/rxin or @yhuai
https://github.com/yhuai, is this a bug that should be fixed for 1.5?


Reply to this email directly or view it on GitHub
#7233 (comment).

_Gaurav Gupta_Engineering Manager @ Adobe
9971666780

@andrewor14
Copy link
Contributor

@ggupta81 can you close this patch then since we already have #7928? It's confusing to have both open.

@ggupta81 ggupta81 closed this Aug 5, 2015
@ggupta81
Copy link
Author

ggupta81 commented Aug 5, 2015

Closing this patch since we have #7928 open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants