Skip to content

Fixed First and Last aggregates to compute first and last value per G… #7233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ggupta81 wants to merge 1 commit into from
Closed

Fixed First and Last aggregates to compute first and last value per G… #7233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,27 +722,25 @@ case class CountDistinctFunction(
case class FirstFunction(expr: Expression, base: AggregateExpression) extends AggregateFunction {
def this() = this(null, null) // Required for serialization.

var result: Any = null
var result: MutableLiteral = MutableLiteral(null, expr.dataType)

override def update(input: Row): Unit = {
if (result == null) {
result = expr.eval(input)
if (result.value == null) {
result.value = expr.eval(input)
}
}

override def eval(input: Row): Any = result
override def eval(input: Row): Any = result.value
}

case class LastFunction(expr: Expression, base: AggregateExpression) extends AggregateFunction {
def this() = this(null, null) // Required for serialization.

var result: Any = null
var result: MutableLiteral = MutableLiteral(null, expr.dataType)

override def update(input: Row): Unit = {
result = input
result.value = expr.eval(input)
}

override def eval(input: Row): Any = {
if (result != null) expr.eval(result.asInstanceOf[Row]) else null
}
override def eval(input: Row): Any = result.value
}