WW-5340 Introducing OGNL Guard #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kusalk
force-pushed
the
WW-5340-ognl-guard
branch
6 times, most recently
from
02db368
to
31cc8a1
Compare
|
Conflicts |
| * | ||
| * @since 6.4.0 | ||
| */ | ||
| public class DefaultOgnlGuard implements OgnlGuard { |
There was a problem hiding this comment.
I prefer to use StrutsOgnlGuard - default means different things for different ppl ;)
kusalk
force-pushed
the
WW-5340-ognl-guard
branch
from
1401f1e
to
f69364b
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
Is it ready for review? |
|
Yep that should be everything addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WW-5340
This serves as an optional, additional layer of protection to
SecurityMemberAccess.OgnlGuardcan validate both the raw and parsed OGNL expression. It is implemented as a user-configurable bean.The default functionality includes the capability to block any expressions which contain specified OGNL AST nodes.