WW-5340 Mild refactor StrutsOgnlGuard for easier subclassing #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kusalk
commented
Oct 5, 2023
| values.add(StringUtils.EMPTY); | ||
| } else if (size > maxStringLength) { | ||
| if (size > maxStringLength) { | ||
| LOG.debug("Form field {} of size {} bytes exceeds limit of {}.", item.getFieldName(), size, maxStringLength); |
Member
Author
There was a problem hiding this comment.
Just added this line, no other functional changes here
Member
Author
There was a problem hiding this comment.
I think logging the field name at the debug level is fine in terms of security?
Member
There was a problem hiding this comment.
I assume so, yet this is a user controlled value so maybe it needs escaping
Member
Author
There was a problem hiding this comment.
Not sure a field name can even contain newline characters but anyway SonarCloud is happy now
kusalk
commented
Oct 5, 2023
| return false; | ||
| } | ||
|
|
||
| protected boolean checkNode(Node node) { |
Member
Author
There was a problem hiding this comment.
I separated the recursion logic from the node checking logic so that subclasses don't need to unnecessarily duplicate that code when overriding.
|
Kudos, SonarCloud Quality Gate passed! |
lukaszlenart
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WW-5340
Quick follow-up to #747
See comments