chore: Bump sqlalchemy-utils and cachelib and refresh requirements.txt #10117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
changed the title
Codecov Report
@@ Coverage Diff @@
## master #10117 +/- ##
==========================================
- Coverage 70.48% 65.68% -4.81%
==========================================
Files 590 590
Lines 31171 31167 -4
Branches 3174 3177 +3
==========================================
- Hits 21972 20472 -1500
- Misses 9083 10515 +1432
- Partials 116 180 +64
Continue to review full report at Codecov.
|
villebro
force-pushed
the
villebro/bump-cachelib
branch
from
0f0e605 to
610b8ab
Compare
villebro
force-pushed
the
villebro/bump-cachelib
branch
from
610b8ab to
514ccf5
Compare
dpgaspar
approved these changes
Jun 22, 2020
villebro
changed the title
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
apache#10117) * chore: Bump sqlalchemy-utils and cachelib and refresh requirements.txt * undeprecate EncryptedType * black * reference correct class Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is a collection of small dependency related fixes:
cachelib==0.1doesn't work correctly on Windows (see issue: FileSystemCache.Set fails on windows with OSError pallets-eco/cachelib#12 ). While Superset doesn't officially support Windows, it is known to be used in production. The maintainers ofcachelibwere kind enough to release0.1.1containing the fix, hence this bump.sqlalchemy-utils==0.36.5had a regression which causedEncryptedTypeto stop working (see New enforcement ofStringoverLargeBinaryon EncryptedType breaks existing implementations kvesteri/sqlalchemy-utils#444 ). Bumping to0.36.6fixes the problem. However, starting from0.36.6theEncryptedTypeis deprecated, and will be migrated to the newStringEncryptedTypein an upcoming version, hence restricting to<0.37. Once the newStringEncryptedTypebecomes stable, we need to migrate to it to stay on the latest stable version.requirements.txtwas not regenerated when support for slack was added, leading to some missing dependencies (see feat: superset report slack integration #9810 ). While regenerating the file for the above bumps, these were also pulled in.TEST PLAN
Local testing + CI
ADDITIONAL INFORMATION