issue: FileSystemCache.Set fails on windows with OSError #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on windows os.rename raises OSError if the dst file already exist. it is suggested to use os.replace if we intend to overwrite the destination file `If you want cross-platform overwriting of the destination, use replace().`
|
When will this be released on Alternatively, how can I use it now? |
|
@Adityashaw not sure when it is going to be available on pip. |
This was referenced Jun 15, 2020
|
|
6 tasks
nirawat2564
suggested changes
Apr 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileSystemCache.Set fails on windows with OSError
line 158, in set os.rename(tmp, filename) FileExistsError: [WinError 183] Cannot create a file when that file already exists: on windows os.rename raises OSError if the dst file already exist.it is because of
os.rename. on windows it throws OSError if the dst exists.it is suggested to use
os.replaceif we intend to overwrite the destination file