fix: add validator information to email/slack alerts #10762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonD28
force-pushed
the
jdavis_alert_hotfix
branch
from
cb3f913
to
e6e66f7
Compare
bkyryliuk
approved these changes
Sep 2, 2020
superset/models/alerts.py
Outdated
| @@ -201,3 +202,15 @@ def alert(self) -> RelationshipProperty: | |||
| foreign_keys=[self.alert_id], | |||
| backref=backref("validators", cascade="all, delete-orphan"), | |||
| ) | |||
|
|
|||
| def __str__(self) -> str: | |||
superset/tasks/schedules.py
Outdated
| sql = alert.sql_observer[0].sql if alert.sql_observer else "" | ||
| observation_value = ( | ||
| str(alert.observations[-1].value) if alert.observations else "Value" | ||
| validation_str = ( |
There was a problem hiding this comment.
s/validation_str/ validation_error_message
superset/templates/email/alert.txt
Outdated
| @@ -20,6 +20,7 @@ | |||
| <p><b>SQL Statement:</b></p> | |||
| <code><mark style="background-color: LightGrey; font-size: 1.1em">{{sql}}</mark></code></p> | |||
| <p><b>SQL Result</b>: {{observation_value}}</p> | |||
| <p><b>Reason For Alert</b>: {{validation_str}}</p> | |||
There was a problem hiding this comment.
let's change it here a bit:
Query:
Result:
Reason:
to keep it a bit simpler
JasonD28
force-pushed
the
jdavis_alert_hotfix
branch
from
30c607c
to
9624cf4
Compare
Codecov Report
@@ Coverage Diff @@
## master #10762 +/- ##
==========================================
+ Coverage 59.23% 61.11% +1.88%
==========================================
Files 768 801 +33
Lines 36651 37774 +1123
Branches 3302 3555 +253
==========================================
+ Hits 21710 23086 +1376
+ Misses 14759 14502 -257
- Partials 182 186 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JasonD28
force-pushed
the
jdavis_alert_hotfix
branch
from
9624cf4
to
ee9838e
Compare
JasonD28
added a commit
to JasonD28/incubator-superset
that referenced
this pull request
Sep 3, 2020
* added validator info to alerts * adjusted format of messages * added nits Co-authored-by: Jason Davis <@dropbox.com> (cherry picked from commit 54ae3b0)
amitmiran137
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Sep 7, 2020
…boards_permissions * upstream/master: (32 commits) docs: Add a note to contributing.md on reporting security vulnerabilities (apache#10796) Fix: Include RLS filters for cache keys (apache#10805) feat: filters for database list view (apache#10772) fix: MVC show saved query (apache#10781) added creator column and adjusted order columns (apache#10789) security: disallow uuid package on jinja2 (apache#10794) feat: CRUD REST API for saved queries (apache#10777) fix: disable domain sharding on explore view (apache#10787) fix: can not type `0.05` in `TextControl` (apache#10778) fix: pivot table timestamp grouping (apache#10774) fix: add validator information to email/slack alerts (apache#10762) More Label touchups (margins) (apache#10722) fix: dashboard extra filters (apache#10692) fix: re-installing local superset in cache image (apache#10766) feat: SIP-34 table list view for databases (apache#10705) refactor: convert DatasetList schema filter to use new distinct api (apache#10746) chore: removing fsevents dependency (apache#10751) Fix precommit hook for docs/installation.rst (apache#10759) feat(database): POST, PUT, DELETE API endpoints (apache#10741) docs: Update OAuth configuration in installation.rst (apache#10748) ...
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* added validator info to alerts * adjusted format of messages * added nits Co-authored-by: Jason Davis <@dropbox.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR updates alert messages by adding the reason why a SQL-based alert was triggered. Information is taken from the alert's validator string.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Email:
Slack:
TEST PLAN
ADDITIONAL INFORMATION