fix: pivot table timestamp grouping #10774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
commented
Sep 3, 2020
| for column_name in groupby + columns: | ||
| column = self.datasource.get_column(column_name) | ||
| if column and column.type in ("DATE", "DATETIME", "TIMESTAMP"): | ||
| ts = df[column_name].apply(_format_datetime) | ||
| if column and column.is_temporal: |
There was a problem hiding this comment.
Without calling column.is_temporal, Postgres datasources were not able to identify temporal columns e.g. TIMESTAMP WITHOUT TIMEZONE.
dpgaspar
approved these changes
Sep 3, 2020
superset/viz.py
Outdated
| @@ -856,6 +856,30 @@ def get_aggfunc( | |||
| # only min and max work properly for non-numerics | |||
| return aggfunc if aggfunc in ("min", "max") else "max" | |||
|
|
|||
| @staticmethod | |||
| def _format_datetime(value: Any) -> Any: | |||
There was a problem hiding this comment.
nit: def _format_datetime(value: Union[pd.Timestamp, datetime, date, str]) -> Union[pd.Timestamp, datetime, date, str]:
villebro
added a commit
to preset-io/superset
that referenced
this pull request
Sep 3, 2020
* fix: pivot table timestamp grouping * address comments
villebro
added a commit
that referenced
this pull request
Sep 5, 2020
* fix: pivot table timestamp grouping * address comments
amitmiran137
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Sep 7, 2020
…boards_permissions * upstream/master: (32 commits) docs: Add a note to contributing.md on reporting security vulnerabilities (apache#10796) Fix: Include RLS filters for cache keys (apache#10805) feat: filters for database list view (apache#10772) fix: MVC show saved query (apache#10781) added creator column and adjusted order columns (apache#10789) security: disallow uuid package on jinja2 (apache#10794) feat: CRUD REST API for saved queries (apache#10777) fix: disable domain sharding on explore view (apache#10787) fix: can not type `0.05` in `TextControl` (apache#10778) fix: pivot table timestamp grouping (apache#10774) fix: add validator information to email/slack alerts (apache#10762) More Label touchups (margins) (apache#10722) fix: dashboard extra filters (apache#10692) fix: re-installing local superset in cache image (apache#10766) feat: SIP-34 table list view for databases (apache#10705) refactor: convert DatasetList schema filter to use new distinct api (apache#10746) chore: removing fsevents dependency (apache#10751) Fix precommit hook for docs/installation.rst (apache#10759) feat(database): POST, PUT, DELETE API endpoints (apache#10741) docs: Update OAuth configuration in installation.rst (apache#10748) ...
dpgaspar
pushed a commit
to preset-io/superset
that referenced
this pull request
Sep 10, 2020
* fix: pivot table timestamp grouping * address comments
villebro
added a commit
to preset-io/superset
that referenced
this pull request
Sep 11, 2020
* fix: pivot table timestamp grouping * address comments
villebro
added a commit
that referenced
this pull request
Sep 11, 2020
* fix: pivot table timestamp grouping * address comments
villebro
added a commit
that referenced
this pull request
Sep 16, 2020
* fix: pivot table timestamp grouping * address comments
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* fix: pivot table timestamp grouping * address comments
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* fix: pivot table timestamp grouping * address comments
mistercrunch
added
🍒 0.37.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
With the introduction of making temporal column formattable on
pivot-table(#10637), formatting only worked for some databases. This expands support and adds tests to ensure formatting is applied correctly.AFTER (Postgres)
Smart formatting with monthly timegrain:
BEFORE (Postgres)
Smart formatting doesn't affect format:
TEST PLAN
Local testing on postgres + sqlite + new tests
ADDITIONAL INFORMATION