Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding all icons from the design system to the codebase #11033

Merged
merged 29 commits into from
Sep 25, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
940b48c
error -> error-solid
rusackas Sep 11, 2020
8d3dee7
warning -> warning-solid
rusackas Sep 11, 2020
0c9ec92
all the new icons mixed in!
rusackas Sep 11, 2020
7d84a9d
card-view -> card_view
rusackas Sep 11, 2020
f12c19c
circle-check-solid -> circle_check_solid
rusackas Sep 11, 2020
9307d54
corrected circle-check to new name and correct (stroke) icon
rusackas Sep 11, 2020
2baa30b
sort-asc/desc -> sort_asc/desc
rusackas Sep 11, 2020
ce52521
databases -> database
rusackas Sep 11, 2020
1ca2740
compass -> nav_explore
rusackas Sep 11, 2020
b816534
pencil -> edit-alt
rusackas Sep 12, 2020
606a61b
more pencil migrations
rusackas Sep 12, 2020
90033e2
easy list view rename
rusackas Sep 12, 2020
003b9a1
star -> favorite (changed in Figma)
rusackas Sep 12, 2020
ea8a75b
removing deprecated icon
rusackas Sep 14, 2020
7b0d6d3
renaming icon to mach figma
rusackas Sep 14, 2020
3b2dce4
More -> More Horiz
rusackas Sep 14, 2020
9d2362f
forgot to change this when ranming the file
rusackas Sep 14, 2020
8a8c44c
updating some icon names in use
rusackas Sep 15, 2020
6c24a4c
adding hella icons
rusackas Sep 22, 2020
48763b9
fixing errant viewboxes
rusackas Sep 23, 2020
6062893
removing dropdown-arrow in favor of triangle-down
rusackas Sep 23, 2020
b9baeeb
adding key to storybook map.
rusackas Sep 24, 2020
a74e371
fixing icon component reference
rusackas Sep 24, 2020
97e6830
tweaks to fave star styling to support revised icon
rusackas Sep 24, 2020
ed7a537
fixing a bad icon inclusion
rusackas Sep 24, 2020
37ad7c9
missed a license
rusackas Sep 24, 2020
eacc98c
touchup to virtual dataset... will tweak later.
rusackas Sep 24, 2020
b45b504
e2e fix
rusackas Sep 24, 2020
b299555
linting
rusackas Sep 24, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ describe('Dashboard edit mode', () => {
cy.server();
cy.login();
cy.visit(WORLD_HEALTH_DASHBOARD);
cy.get('.dashboard-header [data-test=pencil]').click();
cy.get('.dashboard-header [data-test=edit-alt]').click();
});

it('remove, and add chart flow', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('Dashboard edit markdown', () => {
cy.get('script').then(nodes => {
numScripts = nodes.length;
});
cy.get('.dashboard-header [data-test=pencil]').click();
cy.get('.dashboard-header [data-test=edit-alt]').click();
cy.get('script').then(nodes => {
// load 5 new script chunks for css editor
expect(nodes.length).to.greaterThan(numScripts);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe('Dashboard save action', () => {
cy.get('.grid-container .box_plot', { timeout: 5000 }); // wait for 5 secs

// remove box_plot chart from dashboard
cy.get('.dashboard-header [data-test=pencil]').click();
cy.get('.dashboard-header [data-test=edit-alt]').click();
cy.get('.fa.fa-trash').last().trigger('click', { force: true });
cy.get('.grid-container .box_plot').should('not.exist');

Expand All @@ -64,7 +64,7 @@ describe('Dashboard save action', () => {

// go back to view mode
cy.wait('@saveRequest');
cy.get('.dashboard-header [data-test=pencil]').click();
cy.get('.dashboard-header [data-test=edit-alt]').click();
cy.get('.grid-container .box_plot').should('not.exist');
});
});
21 changes: 21 additions & 0 deletions superset-frontend/images/icons/alert.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
22 changes: 22 additions & 0 deletions superset-frontend/images/icons/alert_solid.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions superset-frontend/images/icons/binoculars.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions superset-frontend/images/icons/bolt.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions superset-frontend/images/icons/bolt_small.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions superset-frontend/images/icons/bolt_small_run.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions superset-frontend/images/icons/calendar.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions superset-frontend/images/icons/cancel.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
22 changes: 22 additions & 0 deletions superset-frontend/images/icons/cancel_solid.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions superset-frontend/images/icons/cards.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading