feat: adding all icons from the design system to the codebase #11033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
changed the title
rusackas
commented
Sep 24, 2020
| @@ -529,17 +529,6 @@ tr.reactable-column-header th.reactable-header-sortable { | |||
| padding-right: 17px; | |||
| } | |||
|
|
|||
| .fave-unfave-icon { | |||
There was a problem hiding this comment.
this... doesn't seem to really do anything.
rusackas
commented
Sep 24, 2020
| @@ -33,16 +33,16 @@ const NavDropdown = styled(ReactBootstrapNavDropdown)` | |||
|
|
|||
| :after { | |||
| content: ''; | |||
| height: ${({ theme }) => theme.gridUnit}px; | |||
| width: ${({ theme }) => theme.gridUnit * 2}px; | |||
| background: url('/static/assets/images/icons/dropdown-arrow.svg'); | |||
There was a problem hiding this comment.
the dropdown-arrow was small. The triangle-down button is bigger, with padding around it. These changes accommodate the layout change.
rusackas
commented
Sep 24, 2020
| @@ -36,7 +36,6 @@ | |||
| margin-bottom: 40px; | |||
| } | |||
|
|
|||
| .fave-unfave-icon, | |||
There was a problem hiding this comment.
this doesn't appear necessary these days.
rusackas
changed the title
|
it's great~ |
12 tasks
Codecov Report
@@ Coverage Diff @@
## master #11033 +/- ##
==========================================
- Coverage 65.76% 61.60% -4.17%
==========================================
Files 816 816
Lines 38374 38489 +115
Branches 3606 3606
==========================================
- Hits 25238 23712 -1526
- Misses 13028 14591 +1563
- Partials 108 186 +78
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
OMG yes! |
mistercrunch
approved these changes
Sep 25, 2020
amitmiran137
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Sep 27, 2020
…boards_permissions * upstream/master: (46 commits) fix: surface connection error messages on the client (apache#11077) fix(jest): using UTC mock date (apache#11079) removing unused component (apache#11072) changing to the correct hex color (apache#11073) style: remove unecessary padding (apache#11071) fix: database list checkboxes (apache#11068) feat: adding all icons from the design system to the codebase (apache#11033) fix: sql lab autocomplete width (apache#11063) clickable labels have outlines, storybook shows them (apache#11034) fixed routes for customer in docs (apache#11052) Revert "style: fix checkbox color (apache#10970)" (apache#11051) feat: add "created by" to dashboard CRUD view (apache#11030) Changed `tags.py` and `helpers.py` in `models` module: removed disabled pylint rule `unused_import`, changed unused arguments to private and removed disabled rule `unused-argument. Removed redundant rules.` (apache#11037) chore: updated lint rules in models module (apache#11036) Removed disable global pytlint rule `standarderror-builtin` which isn't appearing for Python3 (apache#11038) Enabled argument-differ for bulk_delete (apache#11039) Enabled no-self-use pylint rule in security. Formatter (apache#11041) Changed variable name from capitals to lowercase and changed lint rule (apache#11044) Revert "ESLint: Re-enable rule default-props-match-prop-types (apache#10868)" (apache#11050) feat(saved_queries): add custom api filter for all string & text fields (apache#11031) ... # Conflicts: # superset/config.py # tests/dashboards/api_tests.py
amitmiran137
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Sep 27, 2020
…boards_permissions * upstream/master: (46 commits) fix: surface connection error messages on the client (apache#11077) fix(jest): using UTC mock date (apache#11079) removing unused component (apache#11072) changing to the correct hex color (apache#11073) style: remove unecessary padding (apache#11071) fix: database list checkboxes (apache#11068) feat: adding all icons from the design system to the codebase (apache#11033) fix: sql lab autocomplete width (apache#11063) clickable labels have outlines, storybook shows them (apache#11034) fixed routes for customer in docs (apache#11052) Revert "style: fix checkbox color (apache#10970)" (apache#11051) feat: add "created by" to dashboard CRUD view (apache#11030) Changed `tags.py` and `helpers.py` in `models` module: removed disabled pylint rule `unused_import`, changed unused arguments to private and removed disabled rule `unused-argument. Removed redundant rules.` (apache#11037) chore: updated lint rules in models module (apache#11036) Removed disable global pytlint rule `standarderror-builtin` which isn't appearing for Python3 (apache#11038) Enabled argument-differ for bulk_delete (apache#11039) Enabled no-self-use pylint rule in security. Formatter (apache#11041) Changed variable name from capitals to lowercase and changed lint rule (apache#11044) Revert "ESLint: Re-enable rule default-props-match-prop-types (apache#10868)" (apache#11050) feat(saved_queries): add custom api filter for all string & text fields (apache#11031) ... # Conflicts: # superset/config.py # tests/dashboards/api_tests.py
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
…#11033) * error -> error-solid * warning -> warning-solid * all the new icons mixed in! * card-view -> card_view * circle-check-solid -> circle_check_solid * corrected circle-check to new name and correct (stroke) icon * sort-asc/desc -> sort_asc/desc * databases -> database * compass -> nav_explore * pencil -> edit-alt * more pencil migrations * easy list view rename * star -> favorite (changed in Figma) * removing deprecated icon * renaming icon to mach figma * More -> More Horiz * forgot to change this when ranming the file * updating some icon names in use * adding hella icons * fixing errant viewboxes * removing dropdown-arrow in favor of triangle-down * adding key to storybook map. * fixing icon component reference * tweaks to fave star styling to support revised icon * fixing a bad icon inclusion * missed a license * touchup to virtual dataset... will tweak later. * e2e fix * linting
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds ALL of the icons from the SIP-34 (#8976) design system into the codebase. Many were already here, but under different names, or with different attributes (sizes, etc). Now they're all here, visible in storybook, and existing use cases have been updated to work with updated icons wherever relevant.
Forthcoming steps/PRs:
• Removing any additional hard-coded colors in the SVGs, replacing them with a series of overridable default colors based on Theme variables
• Replacing font-awesome icons with these new icons wherever possible
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION