fix: sql lab autocomplete width #11063
Merged
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Unfortunately, the previous fix doesn't work in production environments because Ace Editor applies a bunch of new CSS when the autocomplete is open, thus overriding the selector in SQL Lab. Because this doesn't repro in dev, and I don't think such a small change is worth a huge amount of investigation, I've added
!important
and a comment.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See the correct class being applied:
TEST PLAN
CI, we can't test this in dev for some reason, so I applied the same css change in our prod env and it worked
ADDITIONAL INFORMATION
to: @suddjian @graceguo-supercat