-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: save query modal/button styling + convert to ant-d modal #11164
Conversation
62b5154
to
620a8c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #11164 +/- ##
==========================================
- Coverage 61.69% 61.17% -0.53%
==========================================
Files 828 828
Lines 39114 39103 -11
Branches 3688 3693 +5
==========================================
- Hits 24133 23921 -212
- Misses 14800 15001 +201
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
SUMMARY
Modal
, rmModalTrigger
hideFooter
option toModal
componentBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
SaveQuery_spec.jsx
ADDITIONAL INFORMATION