Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save query modal/button styling + convert to ant-d modal #11164

Merged
merged 6 commits into from
Oct 6, 2020

Conversation

riahk
Copy link
Contributor

@riahk riahk commented Oct 5, 2020

SUMMARY

  • Fix modal size so buttons stay all on one line
  • Switch to using ant-d Modal, rm ModalTrigger
  • Convert to typescript
  • Add hideFooter option to Modal component

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2020-10-05 at 12 27 03 PM

After:
Screen Shot 2020-10-05 at 12 25 03 PM

TEST PLAN

  • Updated SaveQuery_spec.jsx

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@riahk riahk force-pushed the moriah/save-query-modal-update branch from 62b5154 to 620a8c8 Compare October 6, 2020 16:45
Copy link
Member

@lilykuang lilykuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #11164 into master will decrease coverage by 0.52%.
The diff coverage is 88.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11164      +/-   ##
==========================================
- Coverage   61.69%   61.17%   -0.53%     
==========================================
  Files         828      828              
  Lines       39114    39103      -11     
  Branches     3688     3693       +5     
==========================================
- Hits        24133    23921     -212     
- Misses      14800    15001     +201     
  Partials      181      181              
Flag Coverage Δ
#javascript 62.33% <88.63%> (+0.02%) ⬆️
#python 60.48% <ø> (-0.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/SqlLab/components/SaveQuery.tsx 88.09% <88.09%> (ø)
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 50.90% <100.00%> (ø)
superset-frontend/src/common/components/Modal.tsx 100.00% <100.00%> (ø)
superset/views/database/views.py 62.30% <0.00%> (-25.14%) ⬇️
superset/db_engine_specs/mysql.py 79.59% <0.00%> (-12.25%) ⬇️
superset/db_engine_specs/sqlite.py 65.62% <0.00%> (-9.38%) ⬇️
superset/databases/commands/create.py 82.97% <0.00%> (-8.52%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/db_engine_specs/presto.py 73.65% <0.00%> (-7.78%) ⬇️
superset/db_engine_specs/base.py 79.78% <0.00%> (-7.55%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d7b805...620a8c8. Read the comment docs.

Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nytai nytai merged commit 21c8d67 into apache:master Oct 6, 2020
@nytai nytai deleted the moriah/save-query-modal-update branch October 6, 2020 23:55
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants