Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save query modal/button styling + convert to ant-d modal #11164

Merged
merged 6 commits into from
Oct 6, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix description overwriting title
riahk committed Oct 6, 2020
commit 9f542425e47014c7f5d995848f97f3f8e54dd793
2 changes: 1 addition & 1 deletion superset-frontend/src/SqlLab/components/SaveQuery.tsx
Original file line number Diff line number Diff line change
@@ -56,7 +56,7 @@ export default function SaveQuery({
onUpdate,
saveQueryWarning = null,
}: SaveQueryProps) {
const [description, setDescription] = useState<string>('');
const [description, setDescription] = useState<string>(query.description || '');
const [label, setLabel] = useState<string>(defaultLabel);
const [showSave, setShowSave] = useState<boolean>(false);
const isSaved = !!query.remoteId;
2 changes: 1 addition & 1 deletion superset-frontend/src/SqlLab/components/SqlEditor.jsx
Original file line number Diff line number Diff line change
@@ -530,7 +530,7 @@ class SqlEditor extends React.PureComponent {
<SaveQuery
query={qe}
defaultLabel={
qe.description == null ? qe.title : qe.description
qe.title || qe.description
}
onSave={this.props.actions.saveQuery}
onUpdate={this.props.actions.updateSavedQuery}