Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CSS Templates List Actions #11271

Merged
merged 13 commits into from
Oct 22, 2020

Conversation

riahk
Copy link
Contributor

@riahk riahk commented Oct 14, 2020

SUMMARY

  • Add filters support
  • Add single and bulk delete action functionality
  • Add modified by tooltip
  • Removes SIP_34_CSS_TEMPLATES_UI flag

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2020-10-14 at 11 04 59 AM

Screen Shot 2020-10-14 at 11 05 23 AM

Screen Shot 2020-10-14 at 11 05 30 AM

TEST PLAN

  • Update CssTemplatesList_spec.jsx

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Oct 14, 2020

Codecov Report

Merging #11271 into master will decrease coverage by 7.24%.
The diff coverage is 2.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11271      +/-   ##
==========================================
- Coverage   65.78%   58.53%   -7.25%     
==========================================
  Files         839      800      -39     
  Lines       39828    38550    -1278     
  Branches     3652     3450     -202     
==========================================
- Hits        26200    22565    -3635     
- Misses      13528    15815    +2287     
- Partials      100      170      +70     
Flag Coverage Δ
#cypress 55.83% <0.00%> (-0.25%) ⬇️
#javascript ?
#python 60.00% <50.00%> (-0.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx 1.29% <0.00%> (-79.10%) ⬇️
.../src/views/CRUD/data/savedquery/SavedQueryList.tsx 2.63% <ø> (-59.21%) ⬇️
superset/views/css_templates.py 89.65% <0.00%> (-0.35%) ⬇️
superset/css_templates/api.py 95.45% <100.00%> (+0.10%) ⬆️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/components/Menu/LanguagePicker.tsx 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...uperset-frontend/src/utils/getClientErrorObject.ts 0.00% <0.00%> (-89.19%) ⬇️
... and 290 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0fcda...b5ff769. Read the comment docs.

@riahk riahk requested a review from nytai October 19, 2020 21:11
@nytai
Copy link
Member

nytai commented Oct 20, 2020

#11296 just merged, so let's rebase and make sure everything looks good as this will likely be the last PR for this feature.

@riahk riahk force-pushed the moriah/css-templates-actions branch from 0d13810 to 5ec7c72 Compare October 20, 2020 22:57
@riahk riahk requested a review from nytai October 20, 2020 23:32
Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nytai nytai merged commit a2a614d into apache:master Oct 22, 2020
@nytai nytai deleted the moriah/css-templates-actions branch October 22, 2020 03:33
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants