Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: css template add/edit modal #11296

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Oct 16, 2020

SUMMARY

  • css template add/edit modal

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

https://www.loom.com/share/8d206d73074d4c5bbf804d2e60924b29

TEST PLAN

  • jest test

ADDITIONAL INFORMATION

  • Has associated issue:
  • [] Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@lilykuang lilykuang changed the title feat: css template add/ edit modal feat: css template add/edit modal Oct 16, 2020
@codecov-io
Copy link

codecov-io commented Oct 16, 2020

Codecov Report

Merging #11296 into master will decrease coverage by 0.00%.
The diff coverage is 68.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11296      +/-   ##
==========================================
- Coverage   65.69%   65.68%   -0.01%     
==========================================
  Files         835      836       +1     
  Lines       39659    39771     +112     
  Branches     3610     3647      +37     
==========================================
+ Hits        26052    26122      +70     
- Misses      13498    13540      +42     
  Partials      109      109              
Flag Coverage Δ
#cypress 55.58% <4.90%> (-0.39%) ⬇️
#javascript 62.77% <68.69%> (+0.05%) ⬆️
#python 60.87% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx 80.39% <47.05%> (-16.91%) ⬇️
...d/src/views/CRUD/csstemplates/CssTemplateModal.tsx 72.44% <72.44%> (ø)
superset/db_engine_specs/sqlite.py 65.62% <0.00%> (-9.38%) ⬇️
superset/utils/celery.py 82.14% <0.00%> (-3.58%) ⬇️
superset/result_set.py 96.69% <0.00%> (-1.66%) ⬇️
...set-frontend/src/dashboard/util/getDropPosition.js 90.47% <0.00%> (-1.59%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 64.52% <0.00%> (-0.43%) ⬇️
superset-frontend/src/SqlLab/reducers/sqlLab.js 41.25% <0.00%> (-0.42%) ⬇️
superset-frontend/src/views/CRUD/hooks.ts 78.65% <0.00%> (+2.24%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31e4a90...3fdcf10. Read the comment docs.

@lilykuang lilykuang closed this Oct 16, 2020
@lilykuang lilykuang reopened this Oct 16, 2020
@lilykuang lilykuang force-pushed the lily/css-template-edit-modal branch from ee66ef2 to 8518729 Compare October 16, 2020 15:23
onHide={hide}
primaryButtonName={isEditMode ? t('Save') : t('Add')}
show={show}
width="800px"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, we can do some fun stuff with this, e.g. width={"calc(100% - 100px)"} if you ever feel like it :D

If/when there are a lot of these modals kicking around, we should probably add a limited number of preferred values to the Theme or a constants file.

<span className="required">*</span>
</div>
<StyledCssEditor
height="240px"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not be worth the battle, but I'm curious if we could make the modal take up as much room on the screen as it can, and use a flexbox layout within the modal, which would let THIS component take up as much of the layout as possible, rather than limiting its height with a static value.

@lilykuang lilykuang force-pushed the lily/css-template-edit-modal branch from b16f8e1 to 3fdcf10 Compare October 17, 2020 00:59
@lilykuang lilykuang requested a review from rusackas October 17, 2020 01:00
Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nytai nytai merged commit 6f3d4c1 into apache:master Oct 20, 2020
@nytai nytai deleted the lily/css-template-edit-modal branch October 20, 2020 19:15
@nytai nytai mentioned this pull request Oct 20, 2020
11 tasks
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants