feat(alerts/reports): remove SIP_34_UI feature flag

[riahk]

SUMMARY

• Remove SIP_34_ALERTS_UI flag check
• Add check for ALERT_REPORTS feature flag (required for api permissions)
• Should only be merged when new alerts UI is completed

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

• manual testing

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI (?)
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov-io]

Codecov Report

Merging #12085 (009cfe7) into master (8d29381) will decrease coverage by 3.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12085      +/-   ##
==========================================
- Coverage   67.58%   63.72%   -3.87%     
==========================================
  Files         959      959              
  Lines       47221    47208      -13     
  Branches     4620     4620              
==========================================
- Hits        31916    30081    -1835     
- Misses      15193    16943    +1750     
- Partials      112      184      +72     

Flag	Coverage Δ
cypress	?
javascript	62.74% <ø> (ø)
python	64.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/views/alerts.py	75.00% <ø> (ø)
superset-frontend/src/SqlLab/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupColors.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/chart/ChartContainer.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/reducers/index.js	0.00% <0.00%> (-100.00%)	⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx	0.00% <0.00%> (-100.00%)	⬇️
...t-frontend/src/dashboard/containers/SliceAdder.jsx	0.00% <0.00%> (-100.00%)	⬇️
...-frontend/src/visualizations/presets/MainPreset.js	0.00% <0.00%> (-100.00%)	⬇️
... and 171 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d29381...009cfe7. Read the comment docs.

[nytai]

LGTM

[nytai]

Merging this as the feature will still be behind the ALERT_REPORTS feature flag