fix(report): fix last_eval_dttm sort and more tests #12121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12121 +/- ##
==========================================
- Coverage 66.55% 63.03% -3.52%
==========================================
Files 994 994
Lines 49034 49018 -16
Branches 4977 4977
==========================================
- Hits 32633 30897 -1736
- Misses 16273 17921 +1648
- Partials 128 200 +72
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dpgaspar
requested review from
willbarrett,
lilykuang and
nytai
and removed request for
willbarrett
nytai
reviewed
Dec 18, 2020
superset/app.py
Outdated
|
|
||
| if feature_flag_manager.is_feature_enabled( | ||
| "ALERT_REPORTS" | ||
| ) and feature_flag_manager.is_feature_enabled("SIP_34_ALERTS_UI"): |
There was a problem hiding this comment.
we recently removed SIP_34_ALERTS_UI, ALERT_REPORTS should be the only one going forward.
There was a problem hiding this comment.
#12085 removed it, but looks like there's still a reference in config.py
There was a problem hiding this comment.
ok, all instances of SIP_34_ALERTS_UI are gone
nytai
approved these changes
Dec 21, 2020
lilykuang
approved these changes
Dec 21, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes the following:
last_eval_dttmallowed sort on the API.ModelViewclassAlertReportModelView.Adds more tests to alerts and reports (invalid queries)
New side by side menu:
ADDITIONAL INFORMATION