Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set datasource panel open by default on Explore view #12211

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

kgabryje
Copy link
Member

SUMMARY

Datasource panel is open by default when user enters Explore view

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

CC: @ktmud @junlincc

@kgabryje kgabryje changed the title feat: Set datasource panel open by default on Explore view cosmetic: Set datasource panel open by default on Explore view Dec 29, 2020
@ktmud
Copy link
Member

ktmud commented Dec 29, 2020

Should this state be persistent?

@kgabryje
Copy link
Member Author

Should this state be persistent?

I'm not aware of such requirement. @junlincc What do you think?

@zhaoyongjie
Copy link
Member

can provide the client to save this status?

@junlincc
Copy link
Member

junlincc commented Jan 1, 2021

Should this state be persistent?

I'm not aware of such requirement. @junlincc What do you think?

the data panel should be collapsible at this intermediate stage, we should make it persistent when both drag and drop control panel and panel width resizing are available this year.

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistercrunch mistercrunch reopened this Jan 4, 2021
@junlincc junlincc closed this Jan 5, 2021
@junlincc junlincc reopened this Jan 5, 2021
@junlincc junlincc changed the title cosmetic: Set datasource panel open by default on Explore view feat: Set datasource panel open by default on Explore view Jan 5, 2021
@codecov-io
Copy link

codecov-io commented Jan 5, 2021

Codecov Report

Merging #12211 (f381f92) into master (f3ab1f4) will increase coverage by 0.89%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12211      +/-   ##
==========================================
+ Coverage   66.20%   67.10%   +0.89%     
==========================================
  Files         996      996              
  Lines       49174    49262      +88     
  Branches     4993     5018      +25     
==========================================
+ Hits        32554    33055     +501     
+ Misses      16476    16084     -392     
+ Partials      144      123      -21     
Flag Coverage Δ
cypress 51.29% <100.00%> (+7.19%) ⬆️
javascript 61.13% <0.00%> (+0.01%) ⬆️
python 64.16% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/explore/components/ExploreViewContainer.jsx 78.57% <100.00%> (ø)
superset/db_engine_specs/sqlite.py 65.62% <0.00%> (-9.38%) ⬇️
...rontend/src/explore/components/PropertiesModal.tsx 51.06% <0.00%> (-8.94%) ⬇️
superset/utils/celery.py 96.42% <0.00%> (-3.58%) ⬇️
superset/result_set.py 96.69% <0.00%> (-1.66%) ⬇️
superset/cli.py 33.58% <0.00%> (-0.92%) ⬇️
superset/db_engine_specs/presto.py 82.68% <0.00%> (-0.65%) ⬇️
...et-frontend/src/explore/reducers/exploreReducer.js 43.33% <0.00%> (-0.53%) ⬇️
superset/connectors/sqla/models.py 91.24% <0.00%> (-0.27%) ⬇️
superset/async_events/api.py 100.00% <0.00%> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ab1f4...f381f92. Read the comment docs.

Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ezgif-4-8e5c2d90686c

@kgabryje let's get Fixed width for dataset panel test done as well soon to have a perfect data panel. thanks for the enhancement!

@junlincc junlincc merged commit d204b02 into apache:master Jan 5, 2021
@junlincc junlincc added explore:datapanel Related to the Data panel of Explore Polidea and removed org:polidea labels Jan 8, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:datapanel Related to the Data panel of Explore size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants