-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Set datasource panel open by default on Explore view #12211
Conversation
Should this state be persistent? |
I'm not aware of such requirement. @junlincc What do you think? |
can provide the client to save this status? |
the data panel should be collapsible at this intermediate stage, we should make it persistent when both drag and drop control panel and panel width resizing are available this year. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #12211 +/- ##
==========================================
+ Coverage 66.20% 67.10% +0.89%
==========================================
Files 996 996
Lines 49174 49262 +88
Branches 4993 5018 +25
==========================================
+ Hits 32554 33055 +501
+ Misses 16476 16084 -392
+ Partials 144 123 -21
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@kgabryje let's get Fixed width for dataset panel test done as well soon to have a perfect data panel. thanks for the enhancement!
SUMMARY
Datasource panel is open by default when user enters Explore view
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
CC: @ktmud @junlincc