fix: use cache for csv download #17194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17194 +/- ##
=======================================
Coverage 76.73% 76.73%
=======================================
Files 1039 1039
Lines 55587 55587
Branches 7580 7580
=======================================
Hits 42654 42654
Misses 12683 12683
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eschutho
force-pushed
the
elizabeth/cache-for-csv
branch
from
1b9b113
to
8b38f14
Compare
eschutho
changed the title
eschutho
force-pushed
the
elizabeth/cache-for-csv
branch
from
8b38f14
to
f0c9c05
Compare
|
🏷 2021.42 |
hughhhh
approved these changes
Oct 23, 2021
|
Ha, thanks. I'll put up a follow up that will take care of the result set not matching and also the json. And will write some tests for them, too. |
|
🏷️ 2021.42 |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Oct 25, 2021
(cherry picked from commit 08aab3b)
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes the issue where csv download on explore is not returning the same result as the chart. The results and the full responses are keyed in cache differently. Since we want the csv to match the full results, I'm passing in the result type as full so that it pulls from the correct cache. There are more improvements that we can do later @villebro has a lot of ideas on how we can cache this better, but for now, this is a quick fix for this bug.
Screen.Recording.2021-10-22.at.5.34.51.PM.mov
TESTING INSTRUCTIONS
create a chart with some data, update the data, return to the chart and click to refresh the data. You'll likely see that the results and the chart data are different. Click to download a csv, and it should match the chart data.
ADDITIONAL INFORMATION