fix: use full resultType with csv download on chart in dashboard #17431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Use the full resultType when downloading a csv so that it takes the same cache key as the chart itself. See #17194
This fixes a bug where if you refreshed cache and then downloaded a csv from a dashboard, the csv results would be different than the chart.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
Screen.Recording.2021-11-12.at.5.34.31.PM.mov
TESTING INSTRUCTIONS
We should also test to see that the full csv report download has a row limit.
ADDITIONAL INFORMATION