-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove legacy SIP-15 interim logic/flags #18936
chore: Remove legacy SIP-15 interim logic/flags #18936
Conversation
a77b87d
to
73663b7
Compare
73663b7
to
10f6b4d
Compare
17bee7d
to
19bd602
Compare
0df04df
to
8249f09
Compare
Codecov Report
@@ Coverage Diff @@
## master #18936 +/- ##
==========================================
- Coverage 66.39% 66.37% -0.02%
==========================================
Files 1640 1641 +1
Lines 63507 63475 -32
Branches 6415 6418 +3
==========================================
- Hits 42165 42133 -32
Misses 19681 19681
Partials 1661 1661
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
8249f09
to
42887cb
Compare
42887cb
to
385a34d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for CI pass.
❗ Please consider rebasing your branch to avoid db migration conflicts. |
385a34d
to
e029d56
Compare
❗ Please consider rebasing your branch to avoid db migration conflicts. |
SUMMARY
This PR removes the legacy SIP-15 interim logic/flags. Time range endpoints are no longer configurable and strictly adhere to the
[start, end)
paradigm, i.e., inclusive of the start and exclusive of the end.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
SIP_15_*
logic/flags. This feature has been in flight for a number of years which is sufficient time for institutions to have upgraded. #18906