perf: speed up db migration for deprecating time_range_endpoints #19495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktmud
commented
Apr 1, 2022
| @@ -30,7 +30,6 @@ | |||
|
|
|||
| import sqlalchemy as sa | |||
| from alembic import op | |||
| from sqlalchemy.dialects import postgresql | |||
| @@ -15,6 +15,7 @@ | |||
| # specific language governing permissions and limitations | |||
| # under the License. | |||
| """add_saved_query_foreign_key_to_tab_state | |||
|
|
|||
There was a problem hiding this comment.
Bycatch: this makes superset db history prettier
| @@ -46,8 +46,8 @@ def upgrade(): | |||
| bind = op.get_bind() | |||
| session = db.Session(bind=bind) | |||
|
|
|||
| for slc in session.query(Slice): | |||
| params = json.loads(slc.params or "{}") | |||
There was a problem hiding this comment.
No need to fallback when we already filters to slices definitely have params.
Codecov Report
@@ Coverage Diff @@
## master #19495 +/- ##
==========================================
- Coverage 66.58% 66.54% -0.05%
==========================================
Files 1677 1677
Lines 64238 64238
Branches 6538 6538
==========================================
- Hits 42773 42744 -29
- Misses 19766 19795 +29
Partials 1699 1699
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
serenajiang
approved these changes
Apr 1, 2022
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This speeds up db migrations for deprecating
time_range_endpointsby pre-filtering to the subset of slices with potential changes.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION
time_range_endpointsfrom query context object #19423 chore: Remove legacy SIP-15 interim logic/flags #18936