fix: Clean up custom css when dashboard unmounted #19342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomedina248
requested changes
Mar 23, 2022
| () => () => { | ||
| // need to clean up custom css | ||
| // when dashboard unmounts | ||
| injectCustomCss(''); |
There was a problem hiding this comment.
Looking at line 235, it seems like the function injectCustomCss was designed to handle the cleanup (or that was the intention).
I would recommend reviewing that function and finding out why is it not working.
The useEffect from above should be sufficient then.
diegomedina248
approved these changes
Mar 23, 2022
Codecov Report
@@ Coverage Diff @@
## master #19342 +/- ##
========================================
Coverage 66.59% 66.59%
========================================
Files 1670 1676 +6
Lines 63888 64703 +815
Branches 6510 6519 +9
========================================
+ Hits 42544 43088 +544
- Misses 19655 19924 +269
- Partials 1689 1691 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
approved these changes
Apr 5, 2022
|
LGTM! Thanks! |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 6, 2022
* clean up custom css when dashboard unmounted * resolve comment (cherry picked from commit a88fa89)
|
🏷️ preset:2022.13 |
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
* clean up custom css when dashboard unmounted * resolve comment
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This happened because the previous version didn't clear customCss when dashboard is unmounted.
So user could see injected css unless the browser was refreshed by force or some reason.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
[DEV] Superset - 23 March 2022 - Watch Video
AFTER:
[DEV] Superset - 23 March 2022 - Watch Video
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION