Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Clean up custom css when dashboard unmounted #19342

Merged
merged 3 commits into from
Apr 5, 2022
Merged

fix: Clean up custom css when dashboard unmounted #19342

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4207245
clean up custom css when dashboard unmounted
codemaster08240328 Mar 23, 2022
69b23f2
resolve comment
codemaster08240328 Mar 23, 2022
ab22200
Merge branch 'master' into fix/dashboard-customcss-injection-error
codemaster08240328 Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions superset-frontend/src/dashboard/containers/DashboardPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,15 @@ const DashboardPage: FC = () => {
return () => {};
}, [css]);

useEffect(
() => () => {
// need to clean up custom css
// when dashboard unmounts
injectCustomCss('');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at line 235, it seems like the function injectCustomCss was designed to handle the cleanup (or that was the intention).
I would recommend reviewing that function and finding out why is it not working.
The useEffect from above should be sufficient then.

},
[],
);

useEffect(
() => () => {
// clean up label color
Expand Down