Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing migration to drop deprecated alert tables #19933

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions superset/migrations/versions/276a69d83b28_drop_alerts.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
"""drop alerts

Revision ID: 276a69d83b28
Revises: a9422eeaae74
Create Date: 2022-05-02 18:46:30.124352

"""

# revision identifiers, used by Alembic.
revision = '276a69d83b28'
down_revision = 'a9422eeaae74'

from importlib import import_module

modules = [
import_module("superset.migrations.versions.2f1d15e8a6af_add_alerts")
import_module("superset.migrations.versions.2e5a0ee25ed4_refractor_alerting")
]

def upgrade():
for module in reversed(module):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just drop tables? This looks a little weird. Ideally migrations should not depend on other migrations directly.

module.downgrade()


def downgrade():
for module in modules:
module.upgrade()
Loading