fix: Add missing migration to drop deprecated alert tables #19933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley--remove-obsolete-alert-tables
branch
from
6686e24
to
efbaa34
Compare
etr2460
approved these changes
May 5, 2022
dpgaspar
reviewed
Jun 6, 2022
There was a problem hiding this comment.
@john-bodley seems like CI is failling, maybe just do a "normal" drop table?
craig-rueda
reviewed
Jun 6, 2022
| ] | ||
|
|
||
| def upgrade(): | ||
| for module in reversed(module): |
There was a problem hiding this comment.
Can we just drop tables? This looks a little weird. Ideally migrations should not depend on other migrations directly.
|
Closing as this was handled in #24629. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I was misguided when spelunking through our database to try to find the various tables which house the alerting logic. It seems that the
alerts,alert_logs, andalert_ownerstables are obsolete having been replaced with variousreport_*tables. This PR simply drops the unused tables.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION