chore: Drop rouge constraints and tables

[john-bodley]

SUMMARY

Looking at the current schema,

$ rm superset.db
$ FLASK_DEBUG=true superset db upgrade
$ sqlite3 superset.db
sqlite> .tables
ab_permission               metrics                   
ab_permission_view          query                     
ab_permission_view_role     report_execution_log      
ab_register_user            report_recipient          
ab_role                     report_schedule           
ab_user                     report_schedule_user      
ab_user_role                rls_filter_roles          
ab_view_menu                rls_filter_tables         
alembic_version             row_level_security_filters
alert_logs                  saved_query               
alert_owner                 sl_columns                
alerts                      sl_dataset_columns        
annotation                  sl_dataset_tables         
annotation_layer            sl_dataset_users          
cache_keys                  sl_datasets               
clusters                    sl_table_columns          
columns                     sl_tables                 
css_templates               slice_email_schedules     
dashboard_email_schedules   slice_user                
dashboard_roles             slices                    
dashboard_slices            sql_metrics               
dashboard_user              sql_observations          
dashboards                  sqlatable_user            
datasources                 ssh_tunnels               
dbs                         tab_state                 
druiddatasource_user        table_columns             
dynamic_plugin              table_schema              
embedded_dashboards         tables                    
favstar                     tag                       
filter_sets                 tagged_object             
key_value                   url                       
keyvalue                    user_attribute            
logs                      
sqlite> 

it became apparent that there were a number of rouge tables—those which technically were likely dropped in other migrations—but seem to remain in the database. I speculate maybe these were accidentally skipped when resolving a diamond dependency.

This PR adds a migration to drop these tables. Note that the downgrade is a no-op as there's no reference to the underlying schemas in the code pre-migration. I'm made sure the migration is atomic by first checking that the table exists prior to it being dropped.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided: < 5 seconds
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #24629 (585804f) into master (c53b249) will increase coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 585804f differs from pull request most recent head cfa1325. Consider uploading reports for the commit cfa1325 to get more accurate results

@@            Coverage Diff             @@
##           master   #24629      +/-   ##
==========================================
+ Coverage   68.97%   69.08%   +0.10%     
==========================================
  Files        1907     1907              
  Lines       74153    74153              
  Branches     8182     8182              
==========================================
+ Hits        51148    51225      +77     
+ Misses      20882    20805      -77     
  Partials     2123     2123              

Flag	Coverage Δ
hive	54.14% <ø> (?)
mysql	79.47% <ø> (?)
postgres	79.56% <ø> (ø)
presto	54.04% <ø> (ø)
python	83.54% <ø> (+0.21%)	⬆️
sqlite	78.12% <ø> (ø)
unit	54.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[craig-rueda]

At some point it would be great to compact all of these migrations