fix: Allow dataset owners to see their datasets

[cccs-tom]

SUMMARY

Allow dataset owners to view / access their own datasets.

TESTING INSTRUCTIONS

Detailed steps to reproduce are outlined in #19360.

ADDITIONAL INFORMATION

• Has associated issue: Fixes Dataset permissions: Users are unable to see the datasets that they create #19360
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #20135 (678c353) into master (e2f11d3) will decrease coverage by 12.07%.
The diff coverage is 51.61%.

❗ Current head 678c353 differs from pull request most recent head 6487f8e. Consider uploading reports for the commit 6487f8e to get more accurate results

@@             Coverage Diff             @@
##           master   #20135       +/-   ##
===========================================
- Coverage   66.45%   54.37%   -12.08%     
===========================================
  Files        1721     1721               
  Lines       64497    64549       +52     
  Branches     6805     6811        +6     
===========================================
- Hits        42860    35100     -7760     
- Misses      19905    27716     +7811     
- Partials     1732     1733        +1     

Flag	Coverage Δ
hive	?
mysql	?
postgres	?
presto	53.58% <66.66%> (+0.01%)	⬆️
python	57.64% <76.19%> (-24.99%)	⬇️
sqlite	?
unit	49.43% <76.19%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...plugins/legacy-plugin-chart-heatmap/src/Heatmap.js	0.00% <0.00%> (ø)
...in-chart-echarts/src/MixedTimeseries/buildQuery.ts	100.00% <ø> (ø)
.../plugin-chart-echarts/src/Timeseries/buildQuery.ts	66.66% <ø> (ø)
...hart-pivot-table/src/react-pivottable/utilities.js	0.00% <0.00%> (ø)
...c/SqlLab/components/ExploreResultsButton/index.tsx	100.00% <ø> (ø)
...ts/nativeFilters/FilterBar/ActionButtons/index.tsx	85.71% <ø> (ø)
.../src/explore/components/ControlPanelsContainer.tsx	79.80% <ø> (ø)
...et-frontend/src/explore/reducers/exploreReducer.js	28.75% <0.00%> (ø)
...t-frontend/src/explore/reducers/getInitialState.ts	0.00% <ø> (ø)
superset-frontend/src/utils/localStorageHelpers.ts	90.00% <ø> (ø)
... and 298 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f11d3...6487f8e. Read the comment docs.

[villebro]

LGTM, tested to work both with a logged in user and in anonymous mode (user is undefined):

AFTER

The logged in user is Gamma, who is set as an owner of this particular dataset:

BEFORE

The gamma user doesn't see the owned datasets:

[dpgaspar]

Thank you for the fix. Can you please add tests?

[cccs-tom]

Thank you for the fix. Can you please add tests?

@dpgaspar Yes, no problem. I've been out of the office for the last few days, so I'll get on that this week.

[agusfigueroa-htg]

Hi! By looking at the release notes I see this not being part of 2.0, any idea in which version this fix will be released? Thanks!

[michael-s-molina]

Hi! By looking at the release notes I see this not being part of 2.0, any idea in which version this fix will be released? Thanks!

@agusfigueroa-htg This fix was already included in version 1.5.1 so it's part of 2.0.0 too.

[agusfigueroa-htg]

Amazing, thanks for the info Michael!

…

On Fri, Jul 15, 2022 at 1:47 PM Michael S. Molina ***@***.***> wrote: Hi! By looking at the release notes I see this not being part of 2.0, any idea in which version this fix will be released? Thanks! @agusfigueroa-htg <https://github.com/agusfigueroa-htg> This fix was already included in version 1.5.1 so it's part of 2.0.0 too. — Reply to this email directly, view it on GitHub <#20135 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASNRLXX6LQHTV6HL6O4YJJDVUFFUPANCNFSM5WNRANVA> . You are receiving this because you were mentioned.Message ID: ***@***.***>