Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: always get dashboard_id on dashboard API get endpoint #20894

Merged
merged 6 commits into from
Aug 4, 2022

Conversation

lilykuang
Copy link
Member

SUMMARY

  • this endpoint logger slug or id, here we tried to make it always log id

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Lily Kuang added 2 commits July 27, 2022 13:09
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #20894 (8623999) into master (e4fc556) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #20894      +/-   ##
==========================================
- Coverage   66.37%   66.27%   -0.11%     
==========================================
  Files        1767     1758       -9     
  Lines       67230    67190      -40     
  Branches     7137     7122      -15     
==========================================
- Hits        44625    44530      -95     
- Misses      20779    20841      +62     
+ Partials     1826     1819       -7     
Flag Coverage Δ
hive 53.20% <66.66%> (-0.01%) ⬇️
mysql 81.02% <100.00%> (+<0.01%) ⬆️
postgres ?
presto 53.09% <66.66%> (-0.01%) ⬇️
python 81.49% <100.00%> (-0.08%) ⬇️
sqlite 79.67% <100.00%> (+<0.01%) ⬆️
unit 50.52% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/dashboards/api.py 92.50% <100.00%> (+0.02%) ⬆️
...t-frontend/src/components/DropdownButton/index.tsx 10.00% <0.00%> (-75.00%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset-frontend/src/featureFlags.ts 66.66% <0.00%> (-33.34%) ⬇️
superset/sql_validators/__init__.py 80.00% <0.00%> (-20.00%) ⬇️
superset-frontend/src/components/Select/Select.tsx 67.78% <0.00%> (-19.30%) ⬇️
...frontend/src/SqlLab/components/SaveQuery/index.tsx 57.89% <0.00%> (-16.47%) ⬇️
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 35.29% <0.00%> (-14.71%) ⬇️
superset/db_engine_specs/postgres.py 90.67% <0.00%> (-5.94%) ⬇️
superset-frontend/src/utils/urlUtils.ts 46.80% <0.00%> (-4.11%) ⬇️
... and 52 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

…ily/get-dashboard-for-logger

# Conflicts:
#	superset/models/sql_lab.py
@lilykuang lilykuang merged commit c33af83 into apache:master Aug 4, 2022
@lilykuang lilykuang deleted the lily/get-dashboard-for-logger branch August 4, 2022 00:20
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Aug 4, 2022
…20894)

* chore: always get dashboard_id on dashboard API get endpoint

* lint

* pylint

* fix pylint

* lint

(cherry picked from commit c33af83)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.31 size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants