Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: always get dashboard_id on dashboard API get endpoint #20894

Merged
merged 6 commits into from
Aug 4, 2022
Merged

chore: always get dashboard_id on dashboard API get endpoint #20894

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d8c3b34
chore: always get dashboard_id on dashboard API get endpoint
Jul 27, 2022
3605edd
lint
Jul 27, 2022
a3fbc66
pylint
Jul 27, 2022
ef837cf
fix pylint
Jul 27, 2022
32636e5
lint
Jul 27, 2022
8623999
Merge branch 'master' of https://github.com/preset-io/superset into l…
Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions superset/dashboards/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,13 +285,14 @@ def __repr__(self) -> str:
@protect()
@safe
@statsd_metrics
@event_logger.log_this_with_context(
action=lambda self, *args, **kwargs: f"{self.__class__.__name__}.get",
log_to_statsd=False,
)
@with_dashboard
# pylint: disable=arguments-renamed, arguments-differ
def get(self, dash: Dashboard) -> Response:
@event_logger.log_this_with_extra_payload
# pylint: disable=arguments-differ
def get(
self,
dash: Dashboard,
add_extra_log_payload: Callable[..., None] = lambda **kwargs: None,
) -> Response:
"""Gets a dashboard
---
get:
Expand Down Expand Up @@ -323,6 +324,9 @@ def get(self, dash: Dashboard) -> Response:
$ref: '#/components/responses/404'
"""
result = self.dashboard_get_response_schema.dump(dash)
add_extra_log_payload(
dashboard_id=dash.id, action=f"{self.__class__.__name__}.get"
)
return self.response(200, result=result)

@etag_cache(
Expand Down