chore(deps): unpin holidays dependency version #21091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blocking issue has been fixed upstream
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!
|
@ecederstrand Thanks for the unpinning Holiday! Let's wait for the CI. |
Codecov Report
@@ Coverage Diff @@
## master #21091 +/- ##
=======================================
Coverage 66.27% 66.27%
=======================================
Files 1770 1770
Lines 67524 67524
Branches 7178 7178
=======================================
Hits 44754 44754
Misses 20936 20936
Partials 1834 1834
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
eschutho
pushed a commit
that referenced
this pull request
Sep 20, 2022
The blocking issue has been fixed upstream Co-authored-by: Erik Cederstrand <erik@adamatics.com> (cherry picked from commit d817a1d)
Fahrenheit35
pushed a commit
to Fahrenheit35/superset
that referenced
this pull request
Nov 11, 2022
The blocking issue has been fixed upstream Co-authored-by: Erik Cederstrand <erik@adamatics.com> (cherry picked from commit d817a1d)
mistercrunch
added
🍒 2.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The blocking issue has been fixed upstream. Change suggested in discussion #21089