Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(🦾): bump python "flask-session==0.8.0" #27697

Closed
wants to merge 3 commits into from
Closed

chore(🦾): bump python "flask-session==0.8.0" #27697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
174c899
chore(🦾): bump python flask-session==0.8.0
actions-user Mar 26, 2024
649feda
deprecating SESSION_USE_SIGNER
mistercrunch Mar 27, 2024
fb134db
try noqa
mistercrunch Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions UPDATING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ assists people when migrating to a new version.
files for production use cases! While we never really supported
or should have tried to support docker-compose for production use cases, we now actively
have taken a stance against supporting it. See the PR for details.
- [27697](https://github.com/apache/superset/pull/27697) [minor] flask-session bump leads to them
deprecating `SESSION_USE_SIGNER`, check your configs as this flag won't do anything moving
forward.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this deprecation also:
Deprecate flask_session.filesystem.FileSystemSessionInterface in favor of the broader flask_session.cachelib.CacheLibSessionInterface (2bc7df).

seems it will be replaced by cachelib so this impacts SESSION_TYPE


### Breaking Changes

Expand Down
4 changes: 3 additions & 1 deletion requirements/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ flask-login==0.6.3
# flask-appbuilder
flask-migrate==3.1.0
# via apache-superset
flask-session==0.5.0
flask-session==0.8.0
# via apache-superset
flask-sqlalchemy==2.5.1
# via
Expand Down Expand Up @@ -212,6 +212,8 @@ mdurl==0.1.2
# via markdown-it-py
msgpack==1.0.8
# via apache-superset
msgspec==0.18.6
# via flask-session
nh3==0.2.17
# via apache-superset
numba==0.57.1
Expand Down
3 changes: 1 addition & 2 deletions superset/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1474,7 +1474,6 @@
# from flask_session import RedisSessionInterface
#
# SESSION_SERVER_SIDE = True
# SESSION_USE_SIGNER = True
# SESSION_TYPE = "redis"
# SESSION_REDIS = Redis(host="localhost", port=6379, db=0)
#
Expand Down Expand Up @@ -1704,7 +1703,7 @@
try:
# pylint: disable=import-error,wildcard-import,unused-wildcard-import
import superset_config
from superset_config import * # type: ignore
from superset_config import * # noqa: F403, F401

Check warning on line 1706 in superset/config.py

View check run for this annotation

Codecov / codecov/patch

superset/config.py#L1706 

Added line #L1706 was not covered by tests

print(f"Loaded your LOCAL configuration at [{superset_config.__file__}]")
except Exception:
Expand Down
Loading