Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(🦾): bump python "flask-session==0.8.0" #27697

Closed
wants to merge 3 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

Updates the python "flask-session" library version.

Generated by @supersetbot 🦾

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.83%. Comparing base (a4c5446) to head (fb134db).

Files Patch % Lines
superset/config.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27697      +/-   ##
==========================================
+ Coverage   69.78%   69.83%   +0.05%     
==========================================
  Files        1911     1911              
  Lines       75024    75024              
  Branches     8355     8355              
==========================================
+ Hits        52352    52393      +41     
+ Misses      20622    20581      -41     
  Partials     2050     2050              
Flag Coverage Δ
mysql 77.91% <0.00%> (+0.02%) ⬆️
postgres 78.02% <0.00%> (ø)
presto 53.64% <0.00%> (?)
python 83.03% <0.00%> (+0.11%) ⬆️
sqlite 77.46% <0.00%> (ø)
unit 56.76% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mistercrunch mistercrunch force-pushed the supersetbot-bump-flask-session==0.8.0 branch from f728444 to 3c80bc0 Compare March 27, 2024 02:17
@mistercrunch
Copy link
Member

mistercrunch commented Mar 27, 2024

Reading the CHANGELOG https://flask-session.readthedocs.io/en/latest/changes.html, I greped for things that call to be deprecated and found a reference to SESSION_USE_SIGNER. Removing our reference to it and adding a note to UPDATING.md

@mistercrunch
Copy link
Member

@dpgaspar let me know if you think that's ok

@mistercrunch mistercrunch force-pushed the supersetbot-bump-flask-session==0.8.0 branch from 3c80bc0 to 58114aa Compare March 27, 2024 02:36
@@ -35,6 +35,9 @@ assists people when migrating to a new version.
files for production use cases! While we never really supported
or should have tried to support docker-compose for production use cases, we now actively
have taken a stance against supporting it. See the PR for details.
- [27697](https://github.com/apache/superset/pull/27697) [minor] flask-session bump leads to them
deprecating `SESSION_USE_SIGNER`, check your configs as this flag won't do anything moving
forward.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this deprecation also:
Deprecate flask_session.filesystem.FileSystemSessionInterface in favor of the broader flask_session.cachelib.CacheLibSessionInterface (2bc7df).

seems it will be replaced by cachelib so this impacts SESSION_TYPE

@mistercrunch mistercrunch force-pushed the supersetbot-bump-flask-session==0.8.0 branch from 58114aa to fb134db Compare March 28, 2024 00:21
@mistercrunch
Copy link
Member

closing in favor of #27751 that follows a new branch-naming scheme

@rusackas rusackas deleted the supersetbot-bump-flask-session==0.8.0 branch April 16, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants