-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(🦾): bump python "flask-session==0.8.0" #27697
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #27697 +/- ##
==========================================
+ Coverage 69.78% 69.83% +0.05%
==========================================
Files 1911 1911
Lines 75024 75024
Branches 8355 8355
==========================================
+ Hits 52352 52393 +41
+ Misses 20622 20581 -41
Partials 2050 2050
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f728444
to
3c80bc0
Compare
Reading the CHANGELOG https://flask-session.readthedocs.io/en/latest/changes.html, I greped for things that call to be deprecated and found a reference to |
@dpgaspar let me know if you think that's ok |
3c80bc0
to
58114aa
Compare
@@ -35,6 +35,9 @@ assists people when migrating to a new version. | |||
files for production use cases! While we never really supported | |||
or should have tried to support docker-compose for production use cases, we now actively | |||
have taken a stance against supporting it. See the PR for details. | |||
- [27697](https://github.com/apache/superset/pull/27697) [minor] flask-session bump leads to them | |||
deprecating `SESSION_USE_SIGNER`, check your configs as this flag won't do anything moving | |||
forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have this deprecation also:
Deprecate flask_session.filesystem.FileSystemSessionInterface in favor of the broader flask_session.cachelib.CacheLibSessionInterface (2bc7df).
seems it will be replaced by cachelib
so this impacts SESSION_TYPE
58114aa
to
fb134db
Compare
closing in favor of #27751 that follows a new branch-naming scheme |
Updates the python "flask-session" library version.
Generated by @supersetbot 🦾