Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WiP] ElasticSearch connector integration #2953

Closed
wants to merge 1 commit into from

Conversation

mistercrunch
Copy link
Member

Getting started on adding support for ElasticSearch

@mistercrunch mistercrunch changed the title [WiP] elastic search integration [WiP] ElasticSearch connector integration Jun 12, 2017
@davidecavestro
Copy link

@mistercrunch please let me know if I can contribute someway

@mistercrunch
Copy link
Member Author

I'm going to try and find some time to move forward over the weekend. This may be hard to break into subtasks....

@davidecavestro
Copy link

Great

@Zuckonit
Copy link

sorry, but any update about this feature?

@teamsoo
Copy link

teamsoo commented Aug 8, 2017

@mistercrunch Hi, any update about this super cool feature?

@mistercrunch
Copy link
Member Author

Made a bit of progress but I need more time. The query API is tricky because it's so rich and flexible.

@sureshrag3
Copy link

@mistercrunch - Thanks for working on this. Were you able to make any progress on this feature? We are eagerly waiting to include ES data in our dashboards :)

@mistercrunch
Copy link
Member Author

I made a fair amount of progress, the skeleton of the work that needs to get done is here. I'm not planning on working on this anytime soon if someone else wants to take over.

@@ -190,6 +190,7 @@
DEFAULT_MODULE_DS_MAP = OrderedDict([
('superset.connectors.sqla.models', ['SqlaTable']),
('superset.connectors.druid.models', ['DruidDatasource']),
('superset.connectors.elastic.models', ['ElasticDatasource']),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe is good don't short the name and call it .elasticsearch. and ElasticseachDatasource to avoid confusion with other future datasources.
I don't know at the moment, but maybe in the future people wants integration with other products, for example, Elastic Query from Azure.

@aboganas
Copy link
Contributor

is there any updates on this much needed feature?

@mistercrunch
Copy link
Member Author

I dropped the ball on this, fell off my priority list. If someone wants to pick up where I left off I'll be happy to chime in / review.

@aboganas
Copy link
Contributor

if we start a bounty for this feature, what would be a fair and reasonable price?

@davidecavestro
Copy link

@aboganas @mistercrunch please also note that ElasticSearch exposes a SQL REST API now, so maybe we can get a smoother integration
See https://www.elastic.co/guide/en/elasticsearch/reference/current/sql-rest.html

@mistercrunch
Copy link
Member Author

@davidecavestro then the next step is to find or write a Python dbapi-compliant driver for ES as well as a SQLAlchemy dialect for it. @betodealmeida did just that for Druid, here's what the PR looked like: https://github.com/druid-io/pydruid/pull/110/files

The DBAPI spec is well documented and it's pretty easy to write a SQLAlchemy dialect.

@arpit-agarwal
Copy link

A new PR #5358 with implementation is just got submitted

@kristw kristw added the inactive Inactive for >= 30 days label Jan 23, 2019
@kristw
Copy link
Contributor

kristw commented Jan 23, 2019

Close this in favor of #5358

@kristw kristw closed this Jan 23, 2019
@mistercrunch
Copy link
Member Author

mistercrunch commented Oct 25, 2019

#8441 does this leveraging the relatively new SQL support in ElasticSearch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Inactive for >= 30 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants