Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WiP] ElasticSearch connector integration #2953

Closed
wants to merge 1 commit into from
Closed

[WiP] ElasticSearch connector integration #2953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions superset/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@
DEFAULT_MODULE_DS_MAP = OrderedDict([
('superset.connectors.sqla.models', ['SqlaTable']),
('superset.connectors.druid.models', ['DruidDatasource']),
('superset.connectors.elastic.models', ['ElasticDatasource']),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe is good don't short the name and call it .elasticsearch. and ElasticseachDatasource to avoid confusion with other future datasources.
I don't know at the moment, but maybe in the future people wants integration with other products, for example, Elastic Query from Azure.

])
ADDITIONAL_MODULE_DS_MAP = {}
ADDITIONAL_MIDDLEWARE = []
Expand Down
5 changes: 2 additions & 3 deletions superset/connectors/druid/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@

from . import models

appbuilder.add_separator("Sources", )


class DruidColumnInlineView(CompactCRUDMixin, SupersetModelView): # noqa
datamodel = SQLAInterface(models.DruidColumn)
Expand Down Expand Up @@ -283,6 +285,3 @@ def refresh_datasources(self):
category_label=__("Sources"),
category_icon='fa-database',
icon="fa-cog")


appbuilder.add_separator("Sources", )
2 changes: 2 additions & 0 deletions superset/connectors/elastic/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
from . import models # noqa
from . import views # noqa
Loading