Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(frontend): migrate 6 tests from Enzyme to RTL #30151

Merged
merged 13 commits into from
Sep 13, 2024
Merged

refactor(frontend): migrate 6 tests from Enzyme to RTL #30151

merged 13 commits into from
Sep 13, 2024

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Sep 4, 2024 •
edited
Loading

refactor(frontend): migrate 6 tests from Enzyme to RTL

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hainenber
refactor(fe/pkg/ui-core): migrate TooltipTable.test.tsx from Enzyme t…
d786e23 
…o RTL

Signed-off-by: hainenber <dotronghai96@gmail.com>
@mistercrunch
Copy link
Member

Nice! please tag us when this becomes ready for review

@hainenber
refactor(fe/src/explore/comps/controls): refactor SelectControl.test.…
e7ff2a2 
…jsx from Enzyme to RTL

Signed-off-by: hainenber <dotronghai96@gmail.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 7, 2024
@hainenber
refactor(fe/plugins/legacy-chart-partition): refactor OptionDescripti…
e38d8ad 
…on.test.tsx from Enzyme to RTL

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
chore(fe/pkg/ui-core): reduce code duplicate
118abbf 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
refactor(fe/plugin/chart-table): migrate Enzyme-based tests to RTL
ff5a577 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Sep 9, 2024
@hainenber
refactor(fe/core/chart-composition/tooltip): migrate TooltipFrame.tes…
19b0508 
…t.tsx from Enzyme to RTL

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
refactor(fe/src/explore/comps/controls): use jest.runAllTimers to avo…
bbda10b 
…id test timeout

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
refactor(fe/src/comp): refactor FacePile.test.tsx from Enzyme to RTL
f05539e 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber hainenber changed the title refactor(frontend): migrate several tests from Enzyme to RTL refactor(frontend): migrate 6 tests from Enzyme to RTL Sep 10, 2024
@hainenber hainenber marked this pull request as ready for review September 10, 2024 17:01
@dosubot dosubot bot added the frontend:refactor Related to refactoring the frontend label Sep 10, 2024
@hainenber
fix(ci): refactor test to be sync with change from master branch
6a6db8f 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
Copy link
Contributor Author

This is ready for review :D

hainenber and others added 3 commits September 12, 2024 22:31
@hainenber @justinpark
Apply suggestions from justinpark's code review
48bdbd3 
Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
@hainenber
chore: return to real timers after running Jest specs
81ff60c 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
chore: fix eslint issues after pulling remote
86740c2 
Signed-off-by: hainenber <dotronghai96@gmail.com>
justinpark
justinpark approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit e909465 into apache:master Sep 13, 2024
35 checks passed
@hainenber hainenber deleted the migrate-enzyme-to-rtl branch September 14, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinpark justinpark justinpark approved these changes

Assignees
No one assigned
Labels
dependencies:npm frontend:refactor Related to refactoring the frontend packages plugins size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hainenber @mistercrunch @justinpark @rusackas @michael-s-molina