Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(frontend): migrate 6 tests from Enzyme to RTL #30151

Merged
merged 13 commits into from
Sep 13, 2024
Merged

refactor(frontend): migrate 6 tests from Enzyme to RTL #30151

merged 13 commits into from
Sep 13, 2024

Commits on Sep 4, 2024

  1. refactor(fe/pkg/ui-core): migrate TooltipTable.test.tsx from Enzyme t… 

    …o RTL

Signed-off-by: hainenber <dotronghai96@gmail.com>
    @hainenber
    hainenber committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    d786e23 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. refactor(fe/src/explore/comps/controls): refactor SelectControl.test.… 

    …jsx from Enzyme to RTL

Signed-off-by: hainenber <dotronghai96@gmail.com>
    @hainenber
    hainenber committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    e7ff2a2 View commit details
    Browse the repository at this point in the history

  2. refactor(fe/plugins/legacy-chart-partition): refactor OptionDescripti… 

    …on.test.tsx from Enzyme to RTL

Signed-off-by: hainenber <dotronghai96@gmail.com>
    @hainenber
    hainenber committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    e38d8ad View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. chore(fe/pkg/ui-core): reduce code duplicate 

    Signed-off-by: hainenber <dotronghai96@gmail.com>
    @hainenber
    hainenber committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    118abbf View commit details
    Browse the repository at this point in the history

  2. refactor(fe/plugin/chart-table): migrate Enzyme-based tests to RTL 

    Signed-off-by: hainenber <dotronghai96@gmail.com>
    @hainenber
    hainenber committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ff5a577 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. refactor(fe/core/chart-composition/tooltip): migrate TooltipFrame.tes… 

    …t.tsx from Enzyme to RTL

Signed-off-by: hainenber <dotronghai96@gmail.com>
    @hainenber
    hainenber committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    19b0508 View commit details
    Browse the repository at this point in the history

  2. refactor(fe/src/explore/comps/controls): use jest.runAllTimers to avo… 

    …id test timeout

Signed-off-by: hainenber <dotronghai96@gmail.com>
    @hainenber
    hainenber committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    bbda10b View commit details
    Browse the repository at this point in the history

  3. refactor(fe/src/comp): refactor FacePile.test.tsx from Enzyme to RTL 

    Signed-off-by: hainenber <dotronghai96@gmail.com>
    @hainenber
    hainenber committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f05539e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into migrate-enzyme-to-rtl

    @hainenber
    hainenber authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    4399c45 View commit details
    Browse the repository at this point in the history

  5. fix(ci): refactor test to be sync with change from master branch 

    Signed-off-by: hainenber <dotronghai96@gmail.com>
    @hainenber
    hainenber committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    6a6db8f View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Apply suggestions from justinpark's code review 

    Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
    @hainenber @justinpark
    hainenber and justinpark authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    48bdbd3 View commit details
    Browse the repository at this point in the history

  2. chore: return to real timers after running Jest specs 

    Signed-off-by: hainenber <dotronghai96@gmail.com>
    @hainenber
    hainenber committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    81ff60c View commit details
    Browse the repository at this point in the history

  3. chore: fix eslint issues after pulling remote 

    Signed-off-by: hainenber <dotronghai96@gmail.com>
    @hainenber
    hainenber committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    86740c2 View commit details
    Browse the repository at this point in the history