chore: Remove duplicate JOOQ generator and libraries #3748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant JOOQ code generation infrastructure after the functionality was merged into the sbt compiler. The cleanup eliminates duplicate dependencies and unused code to maintain a cleaner codebase.
- Removes the standalone JooqCodeGenerator class that is no longer needed
- Eliminates redundant dependencies for JOOQ code generation, PostgreSQL driver, and Typesafe config
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/dao/src/main/scala/edu/uci/ics/texera/dao/JooqCodeGenerator.scala | Complete removal of the standalone JOOQ code generator class |
| core/dao/build.sbt | Removal of redundant dependencies for code generation and configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@bobbai00 Please review this PR first. |
github-actions
bot
added
dependencies
|
shall we merge this PR now? |
Waiting for @seongjinyoon to add an sbt shortcut to run JOOQ generator in case developers want to run it manually. It's not urgent. Will merge after fixing issue #3917 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the JOOQ code generator logic was merged into the sbt compiler in PR #3746, we no longer need a separate JOOQ generator class. This PR removes the redundant JOOQ generator along with its related libraries.
If you look at the file changes, the files removed in this PR are symmetrical to those added in PR #3746. We chose not to remove everything in the same PR to ensure the new generator worked as expected before deprecating the old one, and to keep each PR minimal and focused.