-
Couldn't load subscription status.
- Fork 107
fix(deployment): deduplicate SQL files under deployment by using symlinks
#3824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deployment): deduplicate SQL files under deployment by using symlinks
#3824
Conversation
- Replace duplicate texera_ddl.sql in Helm chart with symlinks to core SQL files - Create symlinks for all three SQL files: texera_lakefs.sql, iceberg_postgres_catalog.sql, and texera_ddl.sql - Update ConfigMap to execute SQL files in correct order - Maintains single source of truth in core/scripts/sql/ This eliminates duplication and ensures consistency across deployments. Fixes apache#3823 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
deployment by using symlinks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the test case by adding the other two DDL files to github-action-build.yml as well, since you changed the content of texera_ddl.sql.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
This PR eliminates the duplication of SQL DDL files between
core/scripts/sql/anddeployment/k8s/texera-helmchart/files/by replacing duplicate files with symlinks.Changes
texera_ddl.sqlin the Helm chart directory with symlinks to the core SQL filestexera_lakefs.sql→../../../../core/scripts/sql/texera_lakefs.sqliceberg_postgres_catalog.sql→../../../../core/scripts/sql/iceberg_postgres_catalog.sqltexera_ddl.sql→../../../../core/scripts/sql/texera_ddl.sqlBenefits
core/scripts/sql/Fixes #3823